Remove this ad

Lead

Nov 7 13 5:15 PM

Tags : :

Include boost and other goodness when using debian packager

$ diff -u -F3 debian/rules.BAK debian/rules
--- debian/rules.BAK 2013-11-06 00:17:45.571059288 +0000
+++ debian/rules 2013-11-07 15:22:38.720406044 +0000
@@ -326,6 +326,11 @@ export DEB_BUILD_OPTIONS_PARALLEL=3
LDFLAGS="-Wl,--as-needed ${LDFLAGS}"\
--enable-ccache\
--enable-geoip\
+ --enable-optimize\
+ --enable-mmap\
+ --with-zlib\
+ --with-boost\
+ CPPFLAGS="-DASIO_SOCKETS=1"\
${PLASMAMULE}\
${AMULECMD}\
${DEBUGGING}\
Quote    Reply   
Remove this ad
Remove this ad

#1 [url]

Nov 7 13 11:01 PM

Re: 10814 patch: debian/rules

Hm. Doesn't --with-boost set ASIO_SOCKETS on its own?
What's --with-zlib for? We always need zlib.
And I can't imagine Debian builds without optimize.

I'd like Vollstrecker's opinion before messing with Debian anyway.

Quote    Reply   

#2 [url]

Nov 10 13 12:35 PM

Re: 10814 patch: debian/rules

Lines 280-284 set optimize if building only the binary packages. If one -dbg package is built, optimize is disabled.

zlib is used always, so this wouldn't change anything.

I built my packages with boost for a while, so this option is ok, but libboost-system-dev has to be added to Builld-Deps aswell.

For the CPPFLAGS: This is done on line 91 in m4/boost.m4.

Quote    Reply   

#5 [url]

Nov 13 13 12:01 PM

Re: 10814 patch: debian/rules

Theoretically true. Optimze enables -O2 which brings -finline-small-functions,
-findirect-inlining and -fpartial-inlining into compilation, so we could get a backtrace of code inlined, that seems to come from amule-code but originated in an external lib. Fiddling this out has no relation to the benefit of the opt.

Quote    Reply   

#6 [url]

Nov 13 13 9:59 PM

Re: 10814 patch: debian/rules

You know, people are not supposed to run non optimized code which brings lots of performance problems with it, but we want them sometimes to generate a backtrace. If inlined external lib code crashes it's usually not the problem of the lib but the bad data we fed it.

Quote    Reply   
Remove this ad

#8 [url]

Nov 15 13 10:00 AM

Re: 10814 patch: debian/rules

And Btw. there shouldn't be changed anything without a corresponding entry in debian/changelog. And as the --disable-optimize flags is set in $(DEBUGGING) which comes after the change, it wouldn't change anything.

Quote    Reply   

#9 [url]

Dec 28 13 7:28 PM

Re: 10814 patch: debian/rules

we still haven't come to a conclusion about this patch (or variations)

In the meantime I've removed every instace of --disable-optimize on my latest build

Quote    Reply   

#11 [url]

Dec 29 13 12:08 PM

Re: 10814 patch: debian/rules

m4/boost.m4 does at line 91.

Quote    Reply   
Remove this ad
Add Reply

Quick Reply

bbcode help